-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(minor): Reduce dependencies #215
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e ordo datetime dependecy by integrating BenchmarkClock into the benchmark project directly
…n Progress.swift inline in project
dimlio
approved these changes
Jan 8, 2024
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-01-08T10:10:44+00:00 |
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-01-08T10:13:46+00:00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce dependencies from 12->7;
Removing extras-json and instead use Foundations JSON - we have a Foundation dependency anyway and will hopefully soon move to the new swift-foundation.
Fold in Progress.Swift inline with the project instead of depending on Ordo tagged release version
Fold in BenchmarkClock to remove dependency on Ordo package-datetime
Update NIO locks from upstream
Move Benchmarks to a separate embedded project a la SwiftNIO to allow it to use newer toolchain and remove dependencies
Remove DocC plugin dependency as it is done behind the scenes by SPI anyway
How Has This Been Tested?
Test suite and manually tested on macOS
Minimal checklist:
DocC
code-level documentation for any public interfaces exported by the package