Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(minor): Reduce dependencies #215

Merged
merged 7 commits into from
Jan 8, 2024
Merged

chore(minor): Reduce dependencies #215

merged 7 commits into from
Jan 8, 2024

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Dec 28, 2023

Description

Reduce dependencies from 12->7;

Removing extras-json and instead use Foundations JSON - we have a Foundation dependency anyway and will hopefully soon move to the new swift-foundation.

Fold in Progress.Swift inline with the project instead of depending on Ordo tagged release version

Fold in BenchmarkClock to remove dependency on Ordo package-datetime

Update NIO locks from upstream

Move Benchmarks to a separate embedded project a la SwiftNIO to allow it to use newer toolchain and remove dependencies

Remove DocC plugin dependency as it is done behind the scenes by SPI anyway

How Has This Been Tested?

Test suite and manually tested on macOS

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 300 lines in your changes are missing coverage. Please review.

Comparison is base (2e724bf) 70.40% compared to head (a470c6b) 67.18%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   70.40%   67.18%   -3.22%     
==========================================
  Files          29       34       +5     
  Lines        3909     4376     +467     
==========================================
+ Hits         2752     2940     +188     
- Misses       1157     1436     +279     
Files Coverage Δ
Benchmarks/Benchmarks/Histogram/Histogram.swift 44.96% <ø> (ø)
Sources/Benchmark/BenchmarkExecutor.swift 91.67% <ø> (ø)
...ark/MallocStats/MallocStatsProducer+jemalloc.swift 50.57% <0.00%> (ø)
Sources/Benchmark/BenchmarkRunner+ReadWrite.swift 0.00% <0.00%> (ø)
Sources/Benchmark/Progress/ProgressElements.swift 92.42% <92.42%> (ø)
Sources/Benchmark/Progress/Utilities.swift 59.52% <59.52%> (ø)
Sources/Benchmark/Progress/Progress.swift 57.41% <57.41%> (ø)
...rces/Benchmark/NIOConcurrencyHelpers/NIOLock.swift 77.27% <77.27%> (ø)
Sources/Benchmark/BenchmarkClock.swift 33.72% <33.72%> (ø)
Sources/Benchmark/NIOConcurrencyHelpers/lock.swift 1.75% <1.75%> (ø)
Files Coverage Δ
Benchmarks/Benchmarks/Histogram/Histogram.swift 44.96% <ø> (ø)
Sources/Benchmark/BenchmarkExecutor.swift 91.67% <ø> (ø)
...ark/MallocStats/MallocStatsProducer+jemalloc.swift 50.57% <0.00%> (ø)
Sources/Benchmark/BenchmarkRunner+ReadWrite.swift 0.00% <0.00%> (ø)
Sources/Benchmark/Progress/ProgressElements.swift 92.42% <92.42%> (ø)
Sources/Benchmark/Progress/Utilities.swift 59.52% <59.52%> (ø)
Sources/Benchmark/Progress/Progress.swift 57.41% <57.41%> (ø)
...rces/Benchmark/NIOConcurrencyHelpers/NIOLock.swift 77.27% <77.27%> (ø)
Sources/Benchmark/BenchmarkClock.swift 33.72% <33.72%> (ø)
Sources/Benchmark/NIOConcurrencyHelpers/lock.swift 1.75% <1.75%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e724bf...a470c6b. Read the comment docs.

Package.swift Outdated Show resolved Hide resolved
Sources/Benchmark/BenchmarkClock.swift Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Copy link
Contributor

github-actions bot commented Jan 8, 2024

@hassila hassila merged commit c53cdca into main Jan 8, 2024
12 of 16 checks passed
@hassila hassila deleted the reduce-dependencies branch January 8, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants