Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-858]: Move Benchmark to DateTime package #4

Merged

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Nov 29, 2022

Description

Remove date time specific code from benchmark package and use definitions from DateTime instead.

How Has This Been Tested?

Manual testing of basic benchmarks and tests.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@shortcut-integration
Copy link

@github-actions
Copy link

github-actions bot commented Nov 29, 2022

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #4 (21e3b44) into main (26f1193) will increase coverage by 8.06%.
The diff coverage is 55.38%.

❗ Current head 21e3b44 differs from pull request most recent head e19fd02. Consider uploading reports for the commit e19fd02 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   36.76%   44.83%   +8.06%     
==========================================
  Files           3        5       +2     
  Lines         136      261     +125     
==========================================
+ Hits           50      117      +67     
- Misses         86      144      +58     
Impacted Files Coverage Δ
Sources/DateTime/Convenience.swift 0.00% <0.00%> (ø)
Sources/DateTime/InternalUTCClock.swift 43.21% <0.00%> (-5.40%) ⬇️
Sources/DateTime/BenchmarkClock.swift 53.06% <53.06%> (ø)
Tests/DateTimeTests/DateTime.swift 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
Sources/DateTime/Convenience.swift 0.00% <0.00%> (ø)
Sources/DateTime/InternalUTCClock.swift 43.21% <0.00%> (-5.40%) ⬇️
Sources/DateTime/BenchmarkClock.swift 53.06% <53.06%> (ø)
Tests/DateTimeTests/DateTime.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f1193...e19fd02. Read the comment docs.

@hassila hassila merged commit cbfca20 into main Nov 29, 2022
@hassila hassila deleted the feature/sc-858/kill-timestamp-from-datamodel-use-utc-clock branch November 29, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants