Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update QEMU to 4.2-rc0 #182

Closed
wants to merge 2 commits into from
Closed

WIP: Update QEMU to 4.2-rc0 #182

wants to merge 2 commits into from

Conversation

alistair23
Copy link
Member

Signed-off-by: Alistair Francis alistair.francis@wdc.com

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more patches needed? Wow!

@alistair23
Copy link
Member Author

Don't merge! I'm trying to test. My local setup isn't work for some reason

@alistair23
Copy link
Member Author

I am seeing errors like this on my machine:

rust-lld: error: undefined symbol: __atomic_store_16

so I can't test locally.

@rminnich
Copy link
Member

diff --git a/src/soc/sifive/fu540/src/init.S b/src/soc/sifive/fu540/src/init.S
index f3f510c964..fa0c02112f 100644
--- a/src/soc/sifive/fu540/src/init.S
+++ b/src/soc/sifive/fu540/src/init.S
@@ -1,4 +1,9 @@

+.globl __atomic_store_16
+__atomic_store_16:

  •   ret
    

+.globl __atomic_load_16
+__atomic_load_16:

  •   ret
    

.globl _stack_ptr
.section .rodata
_stack_ptr: .word 0x08010000

fixes it.

can riscv do 16-bit aligned atomic load and store? If not, could that be the issue?

@alistair23
Copy link
Member Author

Can you re-paste the diff as a code segment? I can't understand what you are changing.

It only has atomic load/store word and double, so no 16-bit.

@rminnich
Copy link
Member

annoying github.

`+.globl __atomic_store_16
+__atomic_store_16:

  •   ret
    

+.globl __atomic_load_16
+__atomic_load_16:

  •   ret
    

.globl _stack_ptr
.section .rodata
_stack_ptr: .word 0x08010000`

@rminnich
Copy link
Member

alistair, does this work for you too?

@alistair23
Copy link
Member Author

Yep, that fix works for me. I'm going to close this PR and open a correct one.

@alistair23 alistair23 closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants