Several patches to get a rome crb working. #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rminnich
requested review from
alistair23,
fotonick,
GanShun,
rjoleary and
a team
doriath
reviewed
Aug 4, 2020
| area@0 { | ||
| description = "Boot Blob"; | ||
| compatible = "ore-bootblob"; | ||
| offset = <0xff0000>; |
There was a problem hiding this comment.
Would it be possible to sort those areas by offset and make sure there are no overlapping areas? Otherwise this will conflict with #269
There was a problem hiding this comment.
The look sorted to me, just reverse order?
rjoleary
previously approved these changes
Aug 5, 2020
rjoleary
previously approved these changes
Aug 5, 2020
Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
They're tiny, we can always remove them. jmporeboot can be dropped anywhere, and will jmp to oreboot right AFTER segment registers are set (so you can ride on existing gdt) loop loops and dumps %al on port 80. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
add a page table generator, use it. We're dying as soon as we turn on paging in cr0. This usually means broken page tables, DAMMIT. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
64 bit mode, and we're out of assembly. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
A mainboard driver will do init functions as needed, as well as supporting read and write. The ClockNode might be useful. Signed-off-by: Ronald G Minnich <rminnich@gmail.com>
rjoleary
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gets all the way into start() in rust.