Add minimal preprocessor for assembly files #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjoleary
reviewed
Jul 16, 2021
jhand2
force-pushed
the
rpp
branch
2 times, most recently
from
55c8ac7
to
f8c96e9
Compare
|
Don't forget to run |
|
This looks good. Just needs a |
Thanks, done! |
LingMan
reviewed
Jul 29, 2021
tools/rpp/src/lib.rs
Outdated
Comment on lines
69
to
77
| let key = match parts.next() { | ||
| Some(k) => k, | ||
| None => { | ||
| return Err(ParsingError::new( | ||
| String::from("#define has no name"), | ||
| ctx.line_num, | ||
| )) | ||
| } | ||
| }; |
There was a problem hiding this comment.
Looks like this could be written a bit shorter like this:
let key = parts.next().ok_or_else(|| ParsingError::new(...))?;Similarly in other places in this PR.
There was a problem hiding this comment.
Thanks for the suggestion! Done.
jhand2
force-pushed
the
rpp
branch
2 times, most recently
from
b29ed9c
to
fdedc86
Compare
In order to support macro definitions and code reuse in oreboot assembly, add a minimal preprocessor library. This library only supports the "#include" and "#define" preprocessor directives and has no toolchain-specific dependencies. Signed-off-by: Jordan Hand <jhand@google.com>
rjoleary
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support macro definitions and code reuse in oreboot
assembly, add a minimal preprocessor library. This library only supports
the "#include" and "#define" preprocessor directives and has no
toolchain-specific dependencies.
Signed-off-by: Jordan Hand jhand@google.com