Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to always add <p> elements within admonitions? #81

Closed
sandersk opened this issue Mar 9, 2015 · 0 comments · Fixed by #82
Closed

Possible to always add <p> elements within admonitions? #81

sandersk opened this issue Mar 9, 2015 · 0 comments · Fixed by #82

Comments

@sandersk
Copy link
Contributor

sandersk commented Mar 9, 2015

Right now, AsciiDoctor generates <p> elements within <div>s for admonitions (notes, tips, warnings) when Admonition Block markup is used. For example, this AsciiDoc:

[NOTE]
====
Here is a note
====

Generates the following HTML:

<div data-type="note">
<p>Here is a note</p>
</div>

But if instead of Admonition Block markup, you use this analogous Admonition Paragraph (see http://www.methods.co.nz/asciidoc/userguide.html#X28) markup:

NOTE: Here is a note

Or this analogous Admonition Paragraph markup:

[NOTE]
Here is a note

It converts without <p> elements:

<div data-type="note">Here is a note
</div>
</section

Would it be possible to change AsciiDoctor handling so that <p> elements are always added within admonitions in HTMLBook output, regardless of whether Admonition Block or Admonition Paragraph markup is used? This would be valuable as having AsciiDoctor consistently generate <p> elements with admonition <div>s would make it easier to style the HTML with CSS.

@sandersk sandersk changed the title Possible to always add <p> elements within admonitions Possible to always add <p> elements within admonitions? Mar 9, 2015
@sarahs sarahs closed this as completed in #82 Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant