Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move 'allowed-control-allow-origin' overwrite #21

Merged
merged 1 commit into from
Feb 4, 2022
Merged

fix: Move 'allowed-control-allow-origin' overwrite #21

merged 1 commit into from
Feb 4, 2022

Conversation

tvsbrent
Copy link
Collaborator

@tvsbrent tvsbrent commented Feb 4, 2022

Summary

  • Move location of logic to overwrite the access-control-allow-origin header outside of another condition.
    • There seems to be no reason for it to be placed where it was, other than it being a mistake.
  • Regenerate the sandbox fixture.
    • This may have been missed with the version 2.x release.
  • Add a new sandbox:open:playback script to allow a developer to run the Cypress GUI in playback-only mode.

Related Issue(s)

n/a

Checklist

@tvsbrent tvsbrent requested a review from a team as a code owner February 4, 2022 18:39
@tvsbrent tvsbrent merged commit f2f50b9 into main Feb 4, 2022
@tvsbrent tvsbrent deleted the fix-allow-origin-header-overwrite branch February 4, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigTheDoug DigTheDoug DigTheDoug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tvsbrent @DigTheDoug