GitHubからリポジトリの情報を取得できるようにした #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orekyuu
commented
Sep 28, 2018
| /** | ||
| * @see <a href="https://developer.github.com/v3/repos/#response">github document</a> | ||
| */ | ||
| public class GithubRepository { |
There was a problem hiding this comment.
GithubRepositoryを取得するのはGithubRepositoryRepository？やばいな。と一瞬考えたがこれが一番わかり易いと思った。いい名前案絶賛募集中です
orekyuu
commented
Sep 28, 2018
|
|
||
| @Test | ||
| public void testFetchRepository() { | ||
| MockRestServiceServer server = MockRestServiceServer.createServer(restTemplate); |
There was a problem hiding this comment.
RestTemplateでAPIを叩くテストをするときはMockRestServiceServerを使うと叩いた先をMockすることができて便利。
orekyuu
commented
Sep 28, 2018
| public void testFetchRepository() { | ||
| MockRestServiceServer server = MockRestServiceServer.createServer(restTemplate); | ||
| //<editor-fold desc="test rest server"> | ||
| server.expect(requestTo("https://api.github.com/user/repos")).andRespond(withSuccess("[\n" + |
There was a problem hiding this comment.
requestToで叩かれるエンドポイントを指定して、andRespondで返したいレスポンスを渡す。仮にrequestToの値が間違っていればテストが落ちてくれる。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #2
リポジトリを登録するときに自分のリポジトリ一覧が見れる必要がある。
GitHubからリポジトリの一覧を持ってこれるようにした。