Fix for variable scope issue #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v2.8.6 method definition for _autoclearCookies has an issue. The value for domains is only ever set once at the top of the method, and is overwritten by any individual row’s domain property in the cookie table blocks. This patch ensures that any override is scoped to that particular row only.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@orestbida not to be a pain, would it be possible to create a new patch release containing this change in the near future? |
|
@at0mat sure, expect a minor version either later today or tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2.8.6 method definition for _autoclearCookies has an issue.
The value for domains is only ever set once at the top of the method, and is overwritten by any individual row’s domain property in the cookie table blocks.
This patch ensures that any override is scoped to that particular row only.