Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save rolls show pass/fail #13

Closed
Tracked by #3
, #9
...
orffen opened this issue Feb 14, 2022 · 1 comment
Closed
Tracked by #3
, #9
...

Save rolls show pass/fail #13

orffen opened this issue Feb 14, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
r12

Comments

@orffen
Copy link
Owner

orffen commented Feb 14, 2022 •
edited

Improve saving throw rolls to show pass/fail result.
@orffen orffen mentioned this issue Feb 14, 2022
Closed
6 tasks
@orffen orffen added this to the rX milestone Feb 14, 2022
@orffen orffen changed the title Saves show pass/fail Save rolls show pass/fail Feb 14, 2022
@orffen orffen added the enhancement New feature or request label Feb 14, 2022
@orffen orffen modified the milestones: r4, r5 Feb 23, 2022
@orffen orffen removed this from the rX milestone Jul 21, 2023
@orffen
Copy link
Owner Author

orffen commented Jul 21, 2023 •
edited

A basic implementation now shows a target number (cb6f6d9); but I think this needs custom chat roll templates and probably a data-target="{{save.value}}" attribute on the rollables; then we can output success/fail depending on whether target number was hit or not in the js handling code.

@orffen orffen mentioned this issue Jul 21, 2023
Open
24 tasks
orffen added a commit that referenced this issue Jul 21, 2023
@orffen
Add success/failure to saving throws (closes #13)
b9c87f0
@orffen orffen closed this as completed Jul 21, 2023
@orffen orffen added this to the r12 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
r12
Development

No branches or pull requests
1 participant
@orffen