Auth/firewall revamp #223
Merged
Auth/firewall revamp #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchitre
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Now I recall how the original design was supposed to work. The binding to the connector was supposed to allow the stateful behavior per connection. Instead of a thread-local variable, the idea was to use a map with the connection to store state. However, I do prefer this stateful design more, so I propose we go with the change.
ngyewch
commented
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revamp of auth/firewall makes it easier to differentiate between connections.
See #222
As discussed, this PR includes breaking/signature changes in the following classes:
org.arl.fjage.auth.AllowAfterAuthorg.arl.fjage.auth.AllowAllorg.arl.fjage.auth.DenyAllorg.arl.fjage.auth.Firewallorg.arl.fjage.remote.MasterContainerI've also had to relax the scope of:
org.arl.fjage.remote.Action