Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gateway names to avoid clashes with wormhole agent #295

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

ettersi
Copy link
Collaborator

@ettersi ettersi commented Nov 20, 2023

  • Changes the agent ID of the C gateway from CGatewayAgent@... to CGateway-... to avoid clashes with the Unet wormhole agent (see Fix Gateway <-> Wormhole interop #294).
  • Factors out the agent ID creation in the Java gateway so all ways of creating a Java gateway lead to the same agent ID.

@ettersi ettersi requested a review from mchitre November 20, 2023 02:14
@ettersi ettersi self-assigned this Nov 20, 2023
@ettersi ettersi merged commit 9c880d5 into master Nov 20, 2023
2 checks passed
@ettersi ettersi deleted the gateway-names branch November 20, 2023 02:20
@ettersi
Copy link
Collaborator Author

ettersi commented Nov 20, 2023

Whoops, turns out I also need the fix to getAgentID() introduced here for Aquarius. Can I bother you for one more release, @mchitre? Really sorry about this. I've tested that this version works, so this should be the last one 🤞

@mchitre
Copy link
Member

mchitre commented Nov 20, 2023

No problem, shortly...

@mchitre
Copy link
Member

mchitre commented Nov 20, 2023

Released fjage 1.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants