Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node query #28

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Fix node query #28

merged 2 commits into from
Jun 4, 2020

Conversation

alexpeits
Copy link
Contributor

I am getting an emacsql error with the current version, probably because the rendered query has the LEFT JOIN after the WHERE clause - this fixes it

WHERE clauses should come after JOINs
@goktug97
Copy link
Member

goktug97 commented Jun 4, 2020

Thank you for the fix. It is interesting that it does work for some people and it also doesn't. There was no error on my part.

@goktug97 goktug97 merged commit 25d4503 into org-roam:master Jun 4, 2020
@alexpeits alexpeits deleted the fix/node-query branch June 4, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants