Added blacklist feature to tag filter. #52
Conversation
|
I will look into it as soon as I got time. Sorry, couldn't replied to your #48 issue.
|
| @@ -135,6 +138,9 @@ | |||
| -o-transition: background-color 500ms ease-out; | |||
| transition: background-color 500ms ease-out; | |||
| } | |||
| .select2-container--default .select2-selection--multiple .select2-selection__choice { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
The reason why I did this was because a white text looked to have a better contrast on green and red tag backgrounds. It also more consistent with the other text on the page because they are all white. We can merge it to
Lines 143 to 145 in a42a355
like so.
.darkmode .select2-container--default .select2-selection--single,
.darkmode .select2-container--default .select2-selection--multiple,
.darkmode .select2-search--dropdown,
.darkmode .select2-results,
.darkmode .select2-container--default .select2-selection--multiple .select2-selection__choice,
.select2-container--default .select2-selection--multiple .select2-selection__choice {
background-color: #1d1e20;
color: #FFFFFF;
}I think it will be better to leave them separate for manageability sake in the future. It will add confusion later on if merged into one css block. background-color:: #1d1e20; won't apply to selection__choice because it is being set to green or red but this may change in the future.
There was a problem hiding this comment.
I think we should modify the css so that it is consistent with the other white text on the screen. Applying to .select2-container--default .select2-selection--multiple .select2-selection__choice applies to .darkmode .select2-container--default .select2-selection--multiple .select2-selection__choice but not the other way around.
I actually don't think there is a point in keeping darkmode .select2-container--default .select2-selection--multiple .select2-selection__choice within css block that applies background-color because it is going to be overrid with green or red.
|
quick question, what is the rational for JSON.parsing and JSON.Stringifying internal objects like filter? |
|
To search the set using the string hash not with an object hash. When you construct a javascript object using the selected dropdown values it will be unique but if you use a string it will have the same hash value with the previous stringifyed object. I don’t know if there is a better solution but this is simple and works without a problem |
- Fixed bug where the variable tag was aliased within vis.filter.
- Fixed bug where reload button doesn't preserve filters.
- Preview mode on by default.
- Rudimentary support for default white and black list members.
- Currently achieved by modifying index.html.
- This will be made available as variables that can be set from
emacs.
- remove debug prints.
|
I think it works quite well now. I am now trying to add so that a default whitelist and blacklist can be configured from emacs. other variables configuring preview on by default or default list type can configured as well with the same system. When I have time, I am planning on looking at how information is being passed from emacs side to this application and pass default variables on startup and reload. what do you think? |
fixes new update to org-roam db query titles -> title and select titles -> files.
|
Thanks for the PR EDIT: Please don't add your defaults to the PRs |
implements #48