org-roam-show-graph: PREFIX to generate a graph but not display it #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrokuan
reviewed
Mar 6, 2020
org-roam.el
Outdated
| (defun org-roam-show-graph () | ||
| "Displays the generated Org-roam graph using `org-roam-graph-viewer'." | ||
| (interactive) | ||
| (defun org-roam-show-graph (prefix) |
There was a problem hiding this comment.
I appreciate the improvements! FWIW, I used org-roam-insert as a style reference for the prefix argument, so perhaps we should change that, too.
This lets the viewer application watch the file, or have the user manually refresh the view rather than, say, opening a new browser tab.
acowley
force-pushed
the
optional-graph-view
branch
from
ec5c607
to
07e9af6
Compare
jethrokuan
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This lets the viewer application watch the file, or have the user manually refresh the view rather than, say, opening a new browser tab.