Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with latest org-id version: advise org-id-find rather than overwriting id link #2432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on May 1, 2024

  1. (fix): advise org-id-find rather than overwriting id link

    There have been recent changes in org-mode to improve `org-id-open' to
    be able to apply search strings in id: links.  But, org-roam overrides
    the `:follow` parameter for id: links to its own `org-roam-id-open'
    function and therefore misses this.
    
    The only change that `org-roam-id-open' makes is to try calling
    `org-roam-id-find' before falling back on `org-id-find'.  This commit
    uses advice to do this directly, thereby integrating better with
    `org-id-open'.
    
    There was some discussion on the org-mode list about adding a custom
    variable to avoid using advice, but this accomplishes the result
    without requiring changes in org:
    
    https://list.orgmode.org/87jzlxjiuf.fsf@localhost/
    ricklupton committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4a449ad View commit details
    Browse the repository at this point in the history