Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable org-roam-completion-system #284

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

khinsen
Copy link
Contributor

@khinsen khinsen commented Mar 12, 2020

Currently implemented choices:

  • 'default for Emacs' completing-read
  • 'helm for Helm
Motivation for this change

Current choices:
 - `'default` for Emacs' `completing-read`
 - `'helm` for Helm
@jethrokuan
Copy link
Member

Looks fantastic, thanks! Mind adding an entry into the changelog, and a short snippet in the configuration.md?

org-roam.el Outdated Show resolved Hide resolved
org-roam.el Outdated Show resolved Hide resolved
@khinsen khinsen requested a review from jethrokuan March 12, 2020 11:18
Copy link
Member

@jethrokuan jethrokuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jethrokuan jethrokuan merged commit 0950ae3 into org-roam:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants