(bugfix): fix inserting backup files into database #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #470, the `and` clause was removed, so `org-roam--org-roam-file-p` returns `t` on `foo.org~` backup files. This PR adds that back in. In addition, the `after-save-hook` function was not checking for whether the file was within the org-roam system, which meant files from outside `org-roam` would also be added into the database. This PR adds a guard clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In #470, the
andclause was removed, soorg-roam--org-roam-file-preturns
tonfoo.org~backup files. This PR adds that back in.In addition, the
after-save-hookfunction was not checking for whetherthe file was within the org-roam system, which meant files from outside
org-roamwould also be added into the database. This PR adds a guardclause.