Ensure that multicite links are correctly split #545
Conversation
org-ref multi-citations are handled by "cite:key1,key2". In the org-roam databases this was previously stored as a single "cite" link to the (non-existing) key "key1,key2". This means that cite backlinks and cite graph behaviour does not work correctly for these links. This fix will split any cite links with a comma into separate links to each individual ref
|
To avoid the long argument in |
Oh nice, that's exactly what I wanted. I didn't know about the dash library, it looks very useful |
| @@ -9,6 +9,7 @@ | |||
| * [#509](https://github.com/jethrokuan/org-roam/pull/509) fix backup files being tracked in database | |||
| * [#509](https://github.com/jethrokuan/org-roam/pull/509) fix external org files being tracked in database | |||
| * [#537](https://github.com/jethrokuan/org-roam/pull/537) quote graphviz node and edge configuration options to allow multi-word configurations | |||
| * [#545](https://github.com/jethrokuan/org-roam/pull/545) fix `org-roam--extract-links` to ensure that multiple citations (`cite:key1,key2`) are split correctly | |||
There was a problem hiding this comment.
Way more diligence than I showed in any of my PRs right there. 🤡
Thanks!
|
Welp, the code might be more readable, and I'd certainly deserve some golf-points for it, but it isn't that much more optimised: ;; Original
(with-selected-window (next-window)
(benchmark 100 '(org-roam--extract-links)))
;; "Elapsed time: 5.322224s (1.574320s in 17 GCs)"
;; Optimised...?
(with-selected-window (next-window)
(benchmark 100 '(org-roam--extract-links)))
;; "Elapsed time: 5.352579s (1.565723s in 17 GCs)"I guess it'd be better if we could get Oh well. ¯\_(ツ)_/¯ |
|
Thanks for your work on this! |
org-ref multi-citations are handled by "cite:key1,key2". In the org-roam databases this was
previously stored as a single "cite" link to the (non-existing) key "key1,key2". This means that
cite backlinks and cite graph behaviour does not work correctly for these links.
This fix will split any cite links with a comma into separate links to each individual ref.
To be honest, I don't really like how this patch changes the readability of
org-roam--extract-links. Because I've basically wrapped the existing code in amapccan, the code to split the multicite links now appears before the code to actually extract the links; in my mind these should be the other way around. In addition, properly indenting would cause a gross diff (I've currently left the original indentation). Not sure how to fix this with my limited emacs-lisp knowledge so suggestions are welcome.Motivation for this change
Fixes #544