Change parent of SyntaxNode to RefCell from Cell
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `Weak` is not `Copy` (and therefore `Option<WeakHandle>>` is not `Copy`) it shouldn't be put into a `Cell`, only a `RefCell`. In a `Cell`, there is be no way to access the content of the parent.
Closed
scarab5q
approved these changes
Oct 22, 2020
scarab5q
approved these changes
Oct 22, 2020
|
Thanks scarab5q! @ngortheone can you look into why the pr can still not be merged? Thanks, and sorry to bother you so much. |
ngortheone
approved these changes
Oct 23, 2020
|
looks like @scarab5q does not have approval power... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Weakis notCopy(and thereforeOption<WeakHandle>>is notCopy) it shouldn't be put into aCell, only aRefCell. In aCell, there is no way to access the content of the parent.