Consistently kill line

[Jell]

Rapid summary

When user has kill-whole-line setting set to 't, sync:ing a remote card with a checkbox would fail (see #270)

What issue does this fix or improve?

Consistently kill line by locally shadowing the user setting.

Have you checked and/or added tests?

Not yet

[coveralls]

Coverage remained the same at 98.404% when pulling 521a133 on Jell:kill_line_fix into 321a745 on org-trello:master.

[ardumont]

Ok.

I need to check this custom's def but this sounds reasonable ^^

Awesome

Thx

On Sat, Jun 4, 2016, 9:47 AM Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/6462130

Coverage remained the same at 98.404% when pulling 521a133
521a133
on Jell:kill_line_fix into 321a745
321a745
on org-trello:master.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#328 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAr33AU1U0xAbtsgkzy4NMu7Gdk944M5ks5qIS2jgaJpZM4IuE74
.

[Jell]

For reference: https://www.gnu.org/software/emacs/manual/html_node/emacs/Killing-by-Lines.html

If the variable kill-whole-line is non-nil, C-k at the very beginning of a line kills the entire line including the following newline. This variable is normally nil.

[ardumont]

For reference: https://www.gnu.org/software/emacs/manual/html_node/emacs/Killing-by-Lines.html

Thanks.

If the variable kill-whole-line is non-nil, C-k at the very beginning of a line kills the entire line including the following newline. This variable is normally nil.

And i need to only remove from beginning of line to the end of line.
So indeed, kill-whole-line must be nil.
You sir, are awesome ^^

test? ... Not yet

My original test miss some context to write the checkbox at point.
That's why this is not captured and that the current test still pass.
I will update accordingly.

PS: Another confirmation, my kill-whole-line is nil.

[Jell]

\o/ Thanks for the quick response and the work you did on this project! Keep up the good work! :)

Cheers!