Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isolines for Alaska #6271

Closed
person142 opened this issue Oct 9, 2023 · 16 comments · Fixed by #6341
Closed

Add isolines for Alaska #6271

person142 opened this issue Oct 9, 2023 · 16 comments · Fixed by #6341
Labels
Elevation Isolines and altitude

Comments

@person142
Copy link

Is your feature request related to a problem? Please describe.
Isolines are disabled for Alaska - this appears to be because of size constraints:

#4580 (comment)

Describe the solution you would like
Isolines enabled for Alaska - or at least some parts of it.

Describe alternatives you have considered
I use other maps for topographical data.

Additional context
A lot of hiking in Alaska is off-trail, so without topographical data you're flying pretty blind. For example, a commonly-climbed off-trail peak around Anchorage is Mount Williwaw:

https://omaps.app/0oznse0M59/Mount_Williwaw

and the map is largely blank for that area.

I'm happy to make PRs to get Alaska supported, though I'm not sure how deep the rabbit hole goes with the space tradeoffs needed. For Alaska in particular I'd guess that people would happily accept a larger map size in exchange for isolines.

@person142 person142 added the Enhancement New feature or request, an improvement of some existing feature label Oct 9, 2023
@Jean-BaptisteC Jean-BaptisteC added Elevation Isolines and altitude and removed Enhancement New feature or request, an improvement of some existing feature labels Oct 9, 2023
@pastk
Copy link
Contributor

pastk commented Oct 10, 2023

@vng

@vng
Copy link
Member

vng commented Oct 10, 2023

I tried a useless poor profile (500m) before and the size increase was insane (something like 150 -> 300 Mb)
Probably, we can try to turn on isolines for some parts (tiles) only ..

@person142
Copy link
Author

person142 commented Oct 11, 2023

Some interesting bounding boxes:

The national parks

The state parks (that I could find OSM bounding boxes for)

That's probably still... a lot... of stuff; I wonder how much that'd blow the size up.

@biodranik
Copy link
Member

Is the big overhead caused by "close to the north Mercator bound" coordinates?

@vng
Copy link
Member

vng commented Oct 11, 2023

@person142 Cool!
Now could you please help to transform it to the list of 1-degree tiles? Like here:
https://github.com/organicmaps/organicmaps/blob/master/data/conf/isolines/countries-to-generate.json#L3368

There is a list of bottom-left (lat-lon) points of 1-degree SRTM tiles, that will be included in isolines generation. Having this list, I can run an isolines generator with say 50 meters step.

Defining (lat, lon) tile means that (lat, lon, lat + 1, lon + 1) bounding box will be with isolines.

Or write some Python script to fetch a list of tiles (with neighbors) from the list of POIs :)

@person142
Copy link
Author

List of tiles here:

tiles.json

Code here:

https://gist.github.com/person142/f2e874ff8d08af4fdefffbe8fe71a0f7

so I can easily regenerate the list if something is amiss - I spot checked the tile locations, but easy to miss something.

@vng
Copy link
Member

vng commented Oct 12, 2023

Great! Could you please make one unique tiles list, like:

"key": "US_Alaska",
        "value": {
            "profileName": "normal",
            "tileCoordsSubset": [
...

@person142
Copy link
Author

This should do the trick:

tiles.json

@vng
Copy link
Member

vng commented Oct 12, 2023

So, normal profile (50m) for these tiles will add approx 150Mb.

@pastk
Copy link
Contributor

pastk commented Oct 12, 2023

So same size as adding 100m for the whole Alaska.

@person142
Copy link
Author

Interesting; I've seen the discussions #6157 and #4163 about isoline density - Alaska is definitely one of those steep places where denser isolines are nice, so going less than 50m might be a bummer (and going to 10m when the improvements ^ happen would be awesome).

i.e. if the 150Mb increase is acceptable I'd probably rather have the 50m lines on a smaller area than less-dense lines on a larger area.

@vng
Copy link
Member

vng commented Oct 15, 2023

Screenshot_20231015_124548_Organic Maps.jpg

@person142
Copy link
Author

Awesome! Got curious and compared:

Denali

Looks like that’s 100m - how much did it end up adding?

@vng
Copy link
Member

vng commented Oct 16, 2023

Actually, 50 meters, they are visible from 200m zoom.
As I estimated before plus 150M. Now Alaska is 300M.

@pastk
Copy link
Contributor

pastk commented Oct 17, 2023

Please make a PR to merge all isolines profiles changes into the master.

@person142
Copy link
Author

I've had an injury and hadn't been able to enjoy the new isolines yet, but now I've had a chance to try out some route planning with them, and they're awesome! Thank you for adding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elevation Isolines and altitude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants