Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newline breaks italic markup #34

Open
hjiang opened this issue Jun 19, 2019 · 4 comments
Open

newline breaks italic markup #34

hjiang opened this issue Jun 19, 2019 · 4 comments

Comments

@hjiang
Copy link

hjiang commented Jun 19, 2019

I'm using Orga with GatsbyJS. I have the following in my post:

... or /The C++ Programming
Language/.

It is rendered as

... or /The C++ Programming Language/.

But if I remove the newline after Programming, it is correctly rendered as

... or The C++ Programming Language.

I suspect other formatting markup may be broken too.

@xiaoxinghu
Copy link
Collaborator

That is an expected behaviour. I know it works differently from org-mode, but it's a temporary compromise. We experience performance issues when doing inline parsing with large paragraphs. See details #6 , in order to properly resolve it, we have to write a real parser instead of relying on regex to do the magic. That's a big work, so for now I turned off multiline inline parsing, so any inline syntax has to be on one line.

@gitonthescene
Copy link

I think that that #47 nearly fixes this with some small chances to inline.ts. I'll commit those to my fork now.

@gitonthescene
Copy link

This seems to do it, with the rest of the changes in the fork.

@GuiltyDolphin
Copy link
Contributor

GuiltyDolphin commented Jul 18, 2021

Support for this is added in #104. In terms of efficiency, #104 appears to be faster than the old implementation (that supported multi-line text markup), but of course I will keep looking at ways to ensure we don't incur extra cost. Search space is bounded (per the spec), so the regular expression doesn't currently need to check more than 2 lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants