how to make an 2048 game in pygame

[JAJIMASTER]

Hello, I'm a student programmer who is making 2048 with pygame, but there's an critical error in my code. The numbers in the game is keep disappearing while playing the game, i tried to fix it but i failed, and i'm asking help for You guys. The code is beneath this line, i wish luck for you!

import pygame as pg
import random
pg.init()
pg.display.set_caption("2048")
map1 = [0,0,0,0]
map2 = [0,0,0,0]
map3 = [0,0,0,0]
map4 = [0,0,0,0]
map = [map1,
       map2,
       map3,
       map4]
cnt = 1
num = 0
num_2 = 0   
x_1 = 0
y_1 = 0
colors = [(200,200,200),(255,255,182),(251,206,177), (255,127,0),(240,86,80), (223,36,59), (242,254,138)]#
start = False
move = 0
font = pg.font.SysFont(None,25)
text = ""
move = 0
Width = 400
Height = 400
Screen = pg.display.set_mode((Width,Height))
px = 0
py = 0
pg.font.SysFont(None,25)

def spawn_numbers():
    global x
    global y
    global start
    x = 0
    y = 0
    cnt = 0

    x=random.randint(0,3)
    y = random.randint(0,3)
    for a_2 in range(4):
        if not map[y][x] == 0:
            while map[y][x] == 0:
                x = random.randint(0,3)
                y = random.randint(0,3)
    if 1 == random.randint(0,9):
        cnt = 4
    else:
        cnt = 2
    map[y][x] = cnt
    
def draw_screen():
    Screen.fill((255,255,255))
    for n in range(4):
        for n_2 in range(4):
            if not map[n][n_2] == 0: 
                if map[n][n_2] == 2:
                    color = 0
                if map[n][n_2] == 4:
                    color = 1
                if map[n][n_2] == 8:
                    color = 2
                if map[n][n_2] == 16:
                    color = 3
                if map[n][n_2] == 32:
                    color = 4
                if map[n][n_2] == 64:
                    color = 5
                if map[n][n_2] >= 128:
                    color = 6
                pg.draw.rect(Screen, colors[color], [n_2*100, n*100, 100, 100])
            if map == 0:
                pass
    for n in range(4):
        for n_2 in range(4):
            if map[n][n_2] == 0:
                pass
            if not map[n][n_2] == 0:
                text = font.render(str(map[n][n_2]),True,(0,0,0))
                Screen.blit(text,(n_2*100+37.5,n*100+37.5))
Running = True
Mousepos = 0
for z in range(2):
    x=random.randint(0,3)
    y = random.randint(0,3)
    for a_2 in range(4):
        if not map[y][x] == 0:
            while not map[y][x] == 0:
                x = random.randint(0,3)
                y = random.randint(0,3)
    if 1 == random.randint(0,2):
        cnt = 4
    else:
        cnt = 2
    map[y][x] = cnt
while Running:
    for event in pg.event.get():
        if event.type == pg.QUIT:
            Running = False
        if event.type == pg.KEYDOWN:
            if event.key == pg.K_RIGHT:
                move = 0
                for y_1 in range(4):
                    for x_1 in reversed(range(4)):
                        if not map[y_1][x_1] == 0:
                            for m in range(3-x_1):
                                if map[y_1][x_1+m+1] == 0:
                                    move = move+1
                                if map[y_1][x_1+m+1] == map[y_1][x_1]:
                                    move = move+1
                                    map[y_1][x_1] = map[y_1][x_1]*2
                                    map[y_1][x_1+m+1] = 0
                            map[y_1][x_1+move] = map[y_1][x_1]
                            if not x_1 == x_1+move:
                                map[y_1][x_1] = 0
                                print(move)
                            move = 0
            if event.key == pg.K_LEFT:
                move = 0
                for y_1 in range(4):
                    for x_1 in range(4):
                        if not map[y_1][x_1] == 0:
                            for m in range(x_1):
                                if map[y_1][x_1-m-1] == 0:
                                    move = move+1
                                if map[y_1][x_1-m-1] == map[y_1][x_1]:
                                    move = move+1
                                    map[y_1][x_1] = map[y_1][x_1]*2
                                    map[y_1][x_1-m-1] = 0 
                            map[y_1][x_1-move] = map[y_1][x_1]
                            if not x_1 == x_1-move:
                                map[y_1][x_1] = 0
                                print(move)
                            move = 0
            if event.key == pg.K_UP:
                move = 0
                for x_1 in range(4):
                    for y_1 in range(4):
                        if not map[y_1][x_1] == 0:
                            for m in range(y_1):
                                if map[y_1-m-1][x_1] == 0:
                                    move = move+1
                                if map[y_1-m-1][x_1] == map[y_1][x_1]:
                                    move = move+1
                                    map[y_1][x_1] = map[y_1][x_1]*2
                                    map[y_1-m-1][x_1] = 0
                            map[y_1-move][x_1] = map[y_1][x_1]
                            if not y_1 == y_1-move:
                                map[y_1][x_1] = 0
                                print(move)
                            move = 0
            if event.key == pg.K_DOWN:
                move = 0
                for x_1 in range(4):
                    for y_1 in reversed (range(4)):
                        if not map[y_1][x_1] == 0 :
                            for m in range(3-y_1):
                                if map[y_1+m+1][x_1] == 0:
                                    move = move+1
                                if map[y_1+m+1][x_1] == map[y_1][x_1]:
                                    move = move+1
                                    map[y_1][x_1] = map[y_1][x_1]*2
                                    map[y_1+m+1][x_1] = 0
                            map[y_1+move][x_1] = map[y_1][x_1]
                            if not move == 0:
                                map[y_1][x_1] = 0
                                print(move)
                            move = 0
            spawn_numbers()

                                    

        draw_screen()
    pg.display.update()

[MarouaneBenbetka]

Hello @JAJIMASTER , i found some errors in your code :

**Tile Movement and Merging:** The logic to move and merge the tiles doesn't account for the situation where tiles merge and then another tile should move into the newly emptied space.
**Drawing Logic Simplification:** The drawing logic is more complex than it needs to be, with repetitive checks that can be streamlined.

this my corrected version if it answers your question mark it as answered please . Good Luck !

import pygame as pg
import random

pg.init()
pg.display.set_caption("2048")
map = [[0, 0, 0, 0] for _ in range(4)]
colors = [(200, 200, 200), (255, 255, 182), (251, 206, 177),
          (255, 127, 0), (240, 86, 80), (223, 36, 59), (242, 254, 138)]
font = pg.font.SysFont(None, 25)
Width, Height = 400, 400
Screen = pg.display.set_mode((Width, Height))


def spawn_numbers():
    empty_tiles = [(x, y) for x in range(4)
                   for y in range(4) if map[x][y] == 0]
    if empty_tiles:
        x, y = random.choice(empty_tiles)
        map[x][y] = 4 if random.randint(0, 9) == 0 else 2


def draw_screen():
    Screen.fill((255, 255, 255))
    for x in range(4):
        for y in range(4):
            val = map[x][y]
            color_index = min(max(val.bit_length() - 1, 0), len(colors) - 1)
            pg.draw.rect(Screen, colors[color_index], [y*100, x*100, 100, 100])
            if val:
                text = font.render(str(val), True, (0, 0, 0))
                text_rect = text.get_rect(center=(y*100+50, x*100+50))
                Screen.blit(text, text_rect)


def combine_row_left(row):
    new_row = [i for i in row if i != 0]
    for i in range(len(new_row)-1):
        if new_row[i] == new_row[i+1]:
            new_row[i] *= 2
            new_row[i+1] = 0
    new_row = [i for i in new_row if i != 0]
    return new_row + [0]*(4-len(new_row))


def move_left():
    for i in range(4):
        map[i] = combine_row_left(map[i])


def rotate_map():
    return [list(x) for x in zip(*map[::-1])]


def move_right():
    global map
    map = rotate_map()
    map = rotate_map()
    move_left()
    map = rotate_map()
    map = rotate_map()


def move_up():
    global map
    map = rotate_map()
    move_left()
    map = rotate_map()
    map = rotate_map()
    map = rotate_map()


def move_down():
    global map
    map = rotate_map()
    map = rotate_map()
    map = rotate_map()
    move_left()
    map = rotate_map()


def main():
    Running = True
    for _ in range(2):
        spawn_numbers()
    draw_screen()
    pg.display.update()
    while Running:
        for event in pg.event.get():
            if event.type == pg.QUIT:
                Running = False
            if event.type == pg.KEYDOWN:
                if event.key == pg.K_RIGHT:
                    move_right()
                    spawn_numbers()
                if event.key == pg.K_LEFT:
                    move_left()
                    spawn_numbers()
                if event.key == pg.K_UP:
                    move_down()
                    spawn_numbers()
                if event.key == pg.K_DOWN:
                    move_up()
                    spawn_numbers()
                draw_screen()
        pg.display.update()


if __name__ == "__main__":
    main()

[MarouaneBenbetka]

you didn't mark my answer as answered

[MarouaneBenbetka]

Did it work man ?