How do I see new code comments in a PR without re-reading the entire PR? #39260
Replies: 2 comments 1 reply
-
Hi @oakkitten 👋 That sounds like some thorough feedback! I personally don't have the experience of reviewing that many comments in a single PR 🤯 So I can only make simple suggestions. Could the filter by conversations be of use? Other Community members has highlighted the ability to filter by commented conversation would be nice - would you agree to be useful in your situation? |
Beta Was this translation helpful? Give feedback.
-
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Question
Body
I feel like I'm missing something obvious here.
I sometimes review PRs that gather hundreds of code comments, and are force-pushed many times. After I am done, the next day I'm struggling with following the new comments from other developers—these seem to be appear all over the place. Specifically,
When someone adds a new non-review code comment to an earlier discussion, it only appears at the place where the original discussion took place, which might be way up the page. This might be in a comment that's hidden because there's too many comments, so I have to unhide all comments to make sure there are no developments. If the conversation was resolved and is collapsed, a new comment does not uncollapse the conversation, so I have to uncollapse all conversations as well.
When someone adds a new review code comment in an already existing conversation, it appears on the timeline (wew!), but there are no references to the previous conversation. So I often find myself Ctrl-F'ing the comment text for the context.
There seems to be no way to single out conversations that I am participating in.
While I have found a browser addon that lets me unhide/uncollapse many comments at once, which helps, I still have to re-read the entire PR to find new commentary. Is there a better way? Am I missing something? Are there perhaps external tools that can help here? I feel like simply displaying all code commentary in chronological order with links to their original locations would help a lot.
Beta Was this translation helpful? Give feedback.
All reactions