GitHub PR filter not working for review:approved

[catenacyber]

Select Topic Area

Bug

Body

https://github.com/OISF/suricata/pulls?q=is%3Aopen+is%3Apr+review%3Aapproved does not show OISF/suricata#8891

Also not that OISF/suricata#8891 does not show in other review filters like
https://github.com/OISF/suricata/pulls?q=is%3Aopen+is%3Apr+review%3Anone
or https://github.com/OISF/suricata/pulls?q=is%3Aopen+is%3Apr+review%3Achanges-requested

From https://docs.github.com/en/issues/tracking-your-work-with-issues/filtering-and-searching-issues-and-pull-requests the filter should show pull requests that a reviewer has approved, and that is the case.

Also note that this feature works on master-6.0.x branch, so it may be related to the CODEOWNERS file somehow

[catenacyber]

gh pr view --json reviewDecision 8891 gives

{
  "reviewDecision": ""
}

while gh pr view --json reviewDecision 8897 gives as expected

{
  "reviewDecision": ""
}

Or gh pr view --json reviewDecision 8870gives as expected

{
  "reviewDecision": "CHANGES_REQUESTED"
}

And gh pr view --json reviews 8891 gives

{
  "reviews": [
    {
      "id": "PRR_kwDOAFKNus5VVU18",
      "author": {
        "login": "victorjulien"
      },
      "authorAssociation": "MEMBER",
      "body": "",
      "submittedAt": "2023-05-17T21:10:43Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "APPROVED",
      "commit": {
        "oid": "5fb0b3b8cb471f5518398426750ec2caad2e47a1"
      }
    },
    {
      "id": "PRR_kwDOAFKNus5VYDkb",
      "author": {
        "login": "jasonish"
      },
      "authorAssociation": "MEMBER",
      "body": "",
      "submittedAt": "2023-05-18T09:32:14Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "APPROVED",
      "commit": {
        "oid": "5fb0b3b8cb471f5518398426750ec2caad2e47a1"
      }
    },
    {
      "id": "PRR_kwDOAFKNus5VYEZG",
      "author": {
        "login": "jlucovsky"
      },
      "authorAssociation": "MEMBER",
      "body": "",
      "submittedAt": "2023-05-18T09:34:35Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "APPROVED",
      "commit": {
        "oid": "5fb0b3b8cb471f5518398426750ec2caad2e47a1"
      }
    }
  ]
}

[catenacyber]

gh pr list --json number,reviewDecision --search "state:open type:pr -review:none" | jq '.[] | select(.reviewDecision=="")' is the hack I found to get approved PRs

Gets now

{
  "number": 8910,
  "reviewDecision": ""
}
{
  "number": 8907,
  "reviewDecision": ""
}
{
  "number": 8878,
  "reviewDecision": ""
}
{
  "number": 8714,
  "reviewDecision": ""
}

[bselwe]

Is there any update on this? I'm facing the same issue in one of joinbuzz repositories.

[catenacyber]

I think you cannot have two negations about review

review:none should be the missing one, no ?

[bselwe]

@catenacyber That's what I tried before, but when a PR is approved by a non-codeowner, then it has a review - so it won't be shown in review:none filter. It is also not shown in review:approved filter as observed in this issue.

Using -review:approved -review:changes_requested seems to do the trick as it returns PRs that are neither approved nor changes requested. Why do you think that having two negations won't work?

[catenacyber]

So, looks like a different problem than the one I reported which seemed fixed this week.

Why do you think that having two negations won't work?

I remember trying and failing... But maybe that got fixed since

[bselwe]

I am using GitHub Search API, maybe there's a difference in results when using CLI? 🤷🏻

[bselwe]

You can try running your search query here on GitHub if you'd like to compare results.

[JustinTRoss]

Has anyone been able to figure out a work-around for this?

(A GitHub search filter whose results include PRs which have been approved by at least one user, though which may or may not have been approved by all required reviewers)