Always show all annotations in a file #9144
Unanswered
AndrewMonteith
asked this question in
Pull Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently GitHub will hide any annotations on any unmodified lines. This can be problematic when a modified line causes a problem with an unmodified line, that we'd like to highlight with an annotation. As an example use case, consider a simple PR bot that's a linter.
BASE:
HEAD:
If the linter scans this PR then we'd want to show an annotation for the variable
two
now being unused. However since it's on an unmodified line then that annotation will be hidden in the 'Files Changed' panel. The annotation is still visible within the Check Run view, but there is no guarentee the user checks that panel. If the annotation was security related then hiding it from the user is especially problematic. Ideally, no matter the line the annotation is on, then it should be visible within the files changed panel.Beta Was this translation helpful? Give feedback.
All reactions