Allow a code owners' PRs to be approved by non-owners #9636
Unanswered
viettrungluu
asked this question in
Pull Requests
Replies: 2 comments 8 replies
-
Related to this, if you have an item in CODEOWNERS which has only a single team assigned, and that team only has a single member at the moment, and that team member creates a PR, it is impossible to get that PR merged if you require CODEOWNER review without an admin override. With the above proposed solution this issue would also be resolved. |
Beta Was this translation helpful? Give feedback.
8 replies
-
This feature would be very useful for our organization 👍 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
With GitHub's CODEOWNERS, every PR must be reviewed/approved by applicable owners, even when the author of the PR is themself an owner. Traditionally (e.g., with Chromium's and Google's OWNERS), an owner can get approval from anyone (and only needs owners approval for files they don't own).
The request is to allow the looser Chromium/Google system to be followed (at what granularity -- file/repository/branch -- is up for discussion).
Rationale
This is extremely invaluable for onboarding new reviewers/owners. In the Chromium/Google/etc. system, new team members can review owners' code and be useful (there's a social contract on owners ensuring that their code is adequately reviewed; typically, easier/more trivial PRs are sent to new members for review first). In GitHub's system, new team members' reviews are fairly useless until they are made code owners. This leads to new members being made code owners too early without enough onboarding.
Examples
Example 1: If I post a PR for files owned by team A and I'm a member of A:
Example 2: If I post a PR for files owned by teams A and B and I am a member of A (but not B):
Beta Was this translation helpful? Give feedback.
All reactions