Add support for TLSv1.2 for WebDAV in Android 4.x #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android 4.1 to 5.0 have support for TLSv1.2 in creating encrypted sockets, but this is (for some reason) disabled by default. This commit adds conditional support for using a TLS socket override with added support for TLSv1.2 in these SDK build versions, in making WebDAV connections.
|
Attaching a self-signed APK, built against SDK version 18 (Android 4.3 Jelly Bean). Hope it's useful to others! |
deuill
commented
Mar 2, 2024
| @@ -59,7 +59,7 @@ buildscript { | |||
|
|
|||
| versions.glide = '4.10.0' | |||
|
|
|||
| versions.sardine = '0.5' | |||
There was a problem hiding this comment.
Version 0.5 brings an upgrade to OKHTTP 4.0, which breaks connections on older Android versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I am aware that this project is currently unmaintained, and even so this change would not make it in as support for pre-5.0 Android versions was dropped in version 1.8.6.
This PR is intended with pushing a patch and APK I had to create to get WebDAV working with modern TLS on an old Android device (or, more specifically, a Blackberry Q10 running its Android emulator). Other people might find it useful. The base of this PR is the
v1.8.5tag.Android 4.1 to 5.0 have support for TLSv1.2 in creating encrypted sockets, but this is (for some reason) disabled by default. This commit adds conditional support for using a TLS socket override with added support for TLSv1.2 in these SDK build versions, in making WebDAV connections.