Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedPreferences puts should use 'apply' instead of 'commit' #72

Closed
adrianchifor opened this issue Aug 11, 2015 · 2 comments
Closed

SharedPreferences puts should use 'apply' instead of 'commit' #72

adrianchifor opened this issue Aug 11, 2015 · 2 comments
Labels
feature request
Milestone
2.1.0

Comments

@adrianchifor
Copy link

Or a new 'put' method with an extra boolean parameter for the option to pick between synchronous (commit) or asynchronous (apply).
@orhanobut
Copy link
Owner

that's a good idea to have both options, but I also think client might need a callback.

@orhanobut orhanobut added this to the 2.1.0 milestone Apr 2, 2018
@orhanobut
Copy link
Owner

I'll change commit to apply for built-in sharedpreferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@orhanobut @adrianchifor