Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): set max of limit_commits to the number of commits #140

Merged
merged 1 commit into from
Jan 22, 2023
Merged

fix(config): set max of limit_commits to the number of commits #140

merged 1 commit into from
Jan 22, 2023

Conversation

musikid
Copy link
Contributor

@musikid musikid commented Jan 22, 2023

Description

Fixes a panic which occurs when the commit limit set in the config is greater than the number of commits.

Motivation and Context

How Has This Been Tested?

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@musikid musikid marked this pull request as ready for review January 22, 2023 13:50
@musikid musikid requested a review from orhun as a code owner January 22, 2023 13:50
@orhun
Copy link
Owner

orhun commented Jan 22, 2023

There seems to be an issue with the formatting. Can you run rustfmt and commit the result?

@musikid
Copy link
Contributor Author

musikid commented Jan 22, 2023

Sorry, I forgot to run it after!

@musikid
Copy link
Contributor Author

musikid commented Jan 22, 2023

There is one test failing, but it seems unrelated to the fix.

orhun
orhun approved these changes Jan 22, 2023
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato!

@orhun orhun changed the title fix(lib): limit value to number of commits fix(config): set max of limit_commits to the number of commits Jan 22, 2023
@orhun orhun merged commit 06f6732 into orhun:main Jan 22, 2023
@chenrui333 chenrui333 mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@musikid @orhun