Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(changelog): add cases for docs: prefix #167

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

beeb
Copy link
Contributor

@beeb beeb commented May 3, 2023

Description

This PR adds test cases for the docs: prefix.

Motivation and Context

The current test suite doesn't test the docs: prefix which is the recommended value for documentation commits for conventional commits. This change adds the relevant test cases.

Closes #164

How Has This Been Tested?

Test cases that were referring doc: were duplicated with docs: instead.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other: tests

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@beeb beeb requested a review from orhun as a code owner May 3, 2023 12:04
@orhun orhun added this to the 1.3.0 milestone May 3, 2023
@orhun
Copy link
Owner

orhun commented May 3, 2023

Thank you for your contribution @beeb! 🐻 Can you go to #165 and pre-empt your opinion before this PR is merged?

@orhun orhun changed the title test: add cases for docs: prefix test(changelog): add cases for docs: prefix Jun 10, 2023
@orhun orhun merged commit 3a717e2 into orhun:main Jun 10, 2023
21 checks passed
@welcome
Copy link

welcome bot commented Jun 10, 2023

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify tests to include docs: prefix
2 participants