Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): add support for special characters in scopes #26

Merged
merged 3 commits into from
Oct 19, 2021
Merged

fix(changelog): add support for special characters in scopes #26

merged 3 commits into from
Oct 19, 2021

Conversation

pataar
Copy link
Contributor

@pataar pataar commented Oct 19, 2021

Description

This upgrades git-conventional which adds the support for different scope formats. See crate-ci/git-conventional#17.

Motivation and Context

This is needed because some scopes, which are correct by the specification, weren't seen as legit scopes.

How Has This Been Tested?

By upgrading the existing tests to include those scopes and running cargo test.

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Tests

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pataar pataar requested a review from orhun as a code owner October 19, 2021 16:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #26 (e1bccf1) into main (f447cc2) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   41.61%   41.92%   +0.32%     
==========================================
  Files          13       13              
  Lines         637      637              
  Branches      169      169              
==========================================
+ Hits          265      267       +2     
+ Misses        280      276       -4     
- Partials       92       94       +2     
Impacted Files Coverage Δ
git-cliff-core/src/repo.rs 34.53% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f447cc2...e1bccf1. Read the comment docs.

@pataar
Copy link
Contributor Author

pataar commented Oct 19, 2021

I'll fix the formatting tomorrow

Thanks!

@orhun
Copy link
Owner

orhun commented Oct 19, 2021

I'll fix the formatting tomorrow

No worries, I just handled it 👍🏼

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for the fix 🐻

@orhun orhun changed the title fix: add support for special characters in scopes fix(changelog): add support for special characters in scopes Oct 19, 2021
@orhun orhun merged commit 10771f4 into orhun:main Oct 19, 2021
@pataar pataar deleted the upgrade-git-conventional branch October 19, 2021 18:45
@pataar pataar mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants