Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): support using PR title in the GitHub template #418

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

orhun
Copy link
Owner

@orhun orhun commented Dec 29, 2023

Description

This PR makes it possible to use the pull request title with the GitHub integration:

* {{ commit.github.pr_title }}

The final context is the following:

"github": {
    "username": "orhun",
    "pr_title": "some things have changed",
    "pr_number": 420,
    "is_first_time": false
}

Motivation and Context

#148

How Has This Been Tested?

Locally / Fixture tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ca4cdb) 42.42% compared to head (667b9a8) 42.53%.
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   42.42%   42.53%   +0.12%     
==========================================
  Files          15       15              
  Lines         995      997       +2     
==========================================
+ Hits          422      424       +2     
  Misses        573      573              
Flag Coverage Δ
unit-tests 42.53% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit 6f32f33 into main Dec 31, 2023
41 checks passed
@orhun orhun deleted the feat/add_pr_title_to_github_context branch December 31, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants