Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): support using PR labels in the GitHub template #467

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Jan 28, 2024

Description

This PR makes it possible to use the pull request labels with the GitHub integration:

* {{ commit.github.pr_labels }}

The final context is the following:

"github": {
    "username": "orhun",
    "pr_title": "some things have changed",
    "pr_number": 420,
    "pr_labels": ["test"],
    "is_first_time": false
}

Motivation and Context

See #461

How Has This Been Tested?

Unit tests.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fe9a74e) 41.40% compared to head (ea60467) 41.30%.

Files Patch % Lines
git-cliff-core/src/release.rs 76.93% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   41.40%   41.30%   -0.10%     
==========================================
  Files          15       15              
  Lines        1029     1034       +5     
==========================================
+ Hits          426      427       +1     
- Misses        603      607       +4     
Flag Coverage Δ
unit-tests 41.30% <76.93%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit 30d15bb into main Jan 28, 2024
42 checks passed
@orhun orhun deleted the feat/add_pr_labels_to_github_context branch January 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants