Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): add GITHUB_REPO variable to GitHub action #597

Merged
merged 1 commit into from Apr 9, 2024

Conversation

clementnuss
Copy link
Contributor

needed in order to generate detailed Github release notes, including e.g. new contributors, etc.

ref:
https://github.com/orhun/git-cliff/blob/main/examples/github.toml https://git-cliff.org/docs/integration/github#setting-up-the-remote

Description

Motivation and Context

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@clementnuss clementnuss requested a review from orhun as a code owner April 9, 2024 11:44
Copy link

welcome bot commented Apr 9, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.27%. Comparing base (9864780) to head (87c9bdc).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   41.27%   41.27%           
=======================================
  Files          15       15           
  Lines        1071     1071           
=======================================
  Hits          442      442           
  Misses        629      629           
Flag Coverage Δ
unit-tests 41.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit 3b74254 into orhun:main Apr 9, 2024
43 of 44 checks passed
@orhun orhun changed the title docs(gh-action): add github_repo env var docs(website): add GITHUB_REPO variable to GitHub action Apr 9, 2024
Copy link

welcome bot commented Apr 9, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants