Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cheat): don't use a pager when no cheat sheet found for the command #10

Merged
merged 1 commit into from Mar 17, 2023
Merged

fix(cheat): don't use a pager when no cheat sheet found for the command #10

merged 1 commit into from Mar 17, 2023

Conversation

figsoda
Copy link
Contributor

@figsoda figsoda commented Mar 16, 2023

Description

cheat.sh doesn't return 404: chubin/cheat.sh#198

Motivation and Context

How Has This Been Tested?

$ cargo run plz 42
   Compiling halp v0.1.3 (/home/figsoda/halp)
    Finished dev [unoptimized + debuginfo] target(s) in 0.37s
     Running `target/debug/halp plz 42`
❤ Select operation · Show cheat sheet
Unknown topic.
Do you mean one of these topics maybe?

    * m4 50
    * p4 50
    * r2 50
    

(ノ´ヮ`)ノ*: ・゚
 Select operation ›
  Show man page
✧ Show cheat sheet
  Exit

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@figsoda figsoda requested a review from orhun as a code owner March 16, 2023 02:09
src/error.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.67% and project coverage change: -0.06 ⚠️

Comparison is base (0ab80fe) 79.83% compared to head (9156919) 79.76%.

❗ Current head 9156919 differs from pull request most recent head f3178a7. Consider uploading reports for the commit f3178a7 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   79.83%   79.76%   -0.06%     
==========================================
  Files          14       14              
  Lines         575      578       +3     
==========================================
+ Hits          459      461       +2     
- Misses        116      117       +1     
Impacted Files Coverage Δ
src/error.rs 100.00% <ø> (ø)
src/helper/docs/cheat.rs 68.09% <66.67%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/helper/docs/cheat.rs Outdated Show resolved Hide resolved
@figsoda figsoda changed the title fix(cheat): abort when no cheat sheet found for the command fix(cheat): don't use a pager when no cheat sheet found for the command Mar 16, 2023
@figsoda figsoda requested a review from orhun March 16, 2023 13:43
@orhun
Copy link
Owner

orhun commented Mar 17, 2023

bors r+

@bors bors bot merged commit 2276a2c into orhun:main Mar 17, 2023
18 checks passed
@figsoda figsoda deleted the cheat branch March 17, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants