feat(args): check version subcommand for version info
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. `zig` binary doesn't have a flag for getting the version information. It requires to run `zig version`.
|
bors r+ |
|
👎 Rejected by too few approved reviews |
|
bors r+ |
|
👎 Rejected because of missing code owner approval |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 14, 2023
8: feat(args): check `version` subcommand for version info r=orhun a=orhun <!--- Thank you for contributing to halp! 🐙 --> ## Description This PR adds `version` subcommand to the list of arguments to check for version info. ## Motivation and Context e.g. `zig` binary doesn't have a flag for getting the version information. It requires to run `zig version`. ## How Has This Been Tested? \- ## Screenshots / Logs (if applicable) \- ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation (no code change) - [ ] Refactor (refactoring production code) - [ ] Other <!--- (provide information) --> ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] My code follows the code style of this project. - [x] I have updated the documentation accordingly. - [x] I have formatted the code with [rustfmt](https://github.com/rust-lang/rustfmt). - [x] I checked the lints with [clippy](https://github.com/rust-lang/rust-clippy). - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
versionsubcommand to the list of arguments to check for version info.Motivation and Context
e.g.
zigbinary doesn't have a flag for getting theversion information. It requires to run
zig version.How Has This Been Tested?
-
Screenshots / Logs (if applicable)
-
Types of Changes
Checklist: