Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the plz menu configurable via the config file #96

Open
0x61nas opened this issue Aug 3, 2023 · 12 comments · May be fixed by #110
Open

make the plz menu configurable via the config file #96

0x61nas opened this issue Aug 3, 2023 · 12 comments · May be fixed by #110
Assignees
Labels
enhancement New feature or request

Comments

@0x61nas
Copy link
Contributor

0x61nas commented Aug 3, 2023

while working on #56 (to add more help providers), I realized that we (or I) are doing this the wrong way. the user may agree or disagree with our choices and we have to provide an easy way for the user to change the plz menu elements as he/she wanted not as we want

Describe the solution you'd like
Instead, we can read a 2D array from the user via the config file or the CLI arguments, or both. this array contains the plz menu elements in the same order that we going to display with, the elements of this array will be in this form:

[ commad|fetch|local, "THE COMMAND | THE BASE URL | THE TOP DIR",  "THE COMMAND ARGS | THE URL FORMAT | THE FILE LOCATION FORMAT" ]

OR something similar

Additional context

@0x61nas 0x61nas added the enhancement New feature or request label Aug 3, 2023
@0x61nas
Copy link
Contributor Author

0x61nas commented Aug 5, 2023

am available to work on this feature btw

@0x61nas
Copy link
Contributor Author

0x61nas commented Aug 5, 2023

for the next major version, I know that you probably wanted to make it after #56 gets merged and I probably caused to delay. am sorry for that

but I guess that is better if we just release a minor version for now to bush all the bug fixes and the simi features that have been added (if we can say) to push it to the users, and we can continue to work on #56 or implementing this request

@orhun
Copy link
Owner

orhun commented Aug 9, 2023

Hmm, I didn't quite get what's wrong with #56, it can still be implemented and we can make it configurable in the future.

if we just release a minor version for now to bush all the bug fixes and the simi features that have been added

Sounds reasonable. Do you think we can go with 0.2.0 now?

@0x61nas
Copy link
Contributor Author

0x61nas commented Aug 9, 2023

it can still be implemented and we can make it configurable in the future.

sounds reasonable, in this case, I think that #56 is ready to review, and I can start to work on this after it gets merged

Sounds reasonable. Do you think we can go with 0.2.0 now?

I think it's time for, we did a much work since 0.1.7

@orhun
Copy link
Owner

orhun commented Aug 9, 2023

Alrighty, I will add a review soon, feel free to mark it as non-draft :3

@0x61nas
Copy link
Contributor Author

0x61nas commented Aug 9, 2023

by the way, if #56 gets merged then we'll probably have to change the CLI interface and remove the added options when we work on this feature

@orhun
Copy link
Owner

orhun commented Aug 9, 2023

Then the release can wait until that's done?

@0x61nas
Copy link
Contributor Author

0x61nas commented Aug 9, 2023

I think so, the current version works just fine(in most cases) and we don't really want frequently break the users' workflow by changing our command-line interface. (at least if we know that we'll remove those changes in the next version)

@orhun
Copy link
Owner

orhun commented Aug 11, 2023

Okay sounds good.

@orhun
Copy link
Owner

orhun commented Aug 17, 2023

#56 is now merged 🥳

We can proceed with the next steps when you have time!

@0x61nas
Copy link
Contributor Author

0x61nas commented Aug 17, 2023

Great, can you assign this issue to me so?

@orhun orhun assigned 0x61nas and unassigned orhun Aug 18, 2023
@orhun
Copy link
Owner

orhun commented Aug 18, 2023

You got it!

@0x61nas 0x61nas linked a pull request Aug 27, 2023 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants