Various code changes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
append can take any number of chars, and there is already a Scheme implementation in mes that uses append2 to implement append. Also, fix the require statement in builtin_append to what it probably should have been.
The former did not correctly determine the length of the symbol name,
resulting in "" all the time. The latter did not properly intern the new
symbol (in case it was not known yet), resulting in
(equal? (string->symbol "newfoo") (string->symbol "newfoo"))
to return #f, and in consequence resulting in the same module being
loaded multiple times.
Used as "page separators" in some scheme files
And override getenv accordingly.
It now dies when trying to load srfi-13 (due to a segfault in the macro let handling code)
For example:
(define-macro (foo1 q)
(let ((qq 0))
(list '+ q qq)))
(define (foo2)
(foo1 0))
Probably could be reverted if someone finds the actual bug. For now, I like the expression without quasiquotes better anyway.
I don't make any claim whether the code should work now, as to be honest I don't understand why things are done how they are done. At least this should reduce segfaults considerably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with fixing symbol->string and string->symbol, but got a few more fixes that came up once module loading worked.
At the moment when trying to load mes/module/mes/boot.scm, it does not segfault, but probably is stuck again in a macro expansion bug.
My suggested readme change comes in a separate pull request, as it may bring up more controversy.
Feel free to cherry-pick what you like and drop what you don't like.