Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further kaem envar improvements #6

Merged
merged 2 commits into from Jan 15, 2020
Merged

Conversation

fosslinux
Copy link
Collaborator

The way it was being done before seemed to break some applications.
Also now it uses less memory since free() does nothing in M2-Planet.

Sorry ^_^ for the extraneous number of pull requests... seems I'm not very good at testing (especially on edge cases)

@fosslinux fosslinux changed the title Further kaem envar improvements WIP: Further kaem envar improvements Jan 9, 2020
@fosslinux
Copy link
Collaborator Author

Please do not yet merge as there is a serious bug in this

@fosslinux fosslinux changed the title WIP: Further kaem envar improvements Further kaem envar improvements Jan 15, 2020
@fosslinux
Copy link
Collaborator Author

Ok this works now. I have tested it extensively.

A PR for cd will come sometime soon. It will be tested better than this feature was the first 2 times.

The way it was being done before seemed to break some applications.
Also now it uses less memory since free() does nothing in M2-Planet.
@oriansj
Copy link
Owner

oriansj commented Jan 15, 2020

Great work

@oriansj oriansj merged commit 19edd0f into oriansj:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants