Skip to content

Commit

Permalink
updating app.json to use the new buildpacks definition and official m…
Browse files Browse the repository at this point in the history
…ulti-buildpack support
  • Loading branch information
craigkerstiens committed Jun 26, 2015
1 parent 50a8bf7 commit afebecc
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .buildpacks

This file was deleted.

11 changes: 9 additions & 2 deletions app.json
Expand Up @@ -22,6 +22,13 @@
"MANDRILL_PASSWORD": "REDACTED",
"MANDRILL_API_KEY": "REDACTED",
"MANDRILL_DOMAIN": "heroku.com",
"BUILDPACK_URL": "https://github.com/ddollar/heroku-buildpack-multi.git"
}
},
"buildpacks" : [
{
"url": "https://github.com/heroku/heroku-buildpack-nodejs"
},
{
"url": "https://github.com/heroku/heroku-buildpack-ruby"
}
]
}

5 comments on commit afebecc

@rwdaigle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke the Deploy to Heroku button:

Best guess is that the trailing comma on line 24 should be removed. JSON is picky like that.

@olivierlacan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigkerstiens You broke my Heroku button. For shame! Is there a new button?

@olivierlacan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwdaigle Oh good call, insta-fix then.

@craigkerstiens
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, that's what i get for copy and pasting without testing...

@olivierlacan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here I was ranting about bad Apple QA on Twitter. Serves me right!

Please sign in to comment.