Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definition file orientjs.d.ts added now . #175

Closed
wants to merge 6 commits into from
Closed

Typescript definition file orientjs.d.ts added now . #175

wants to merge 6 commits into from

Conversation

saeedtabrizi
Copy link
Contributor

Typescript definition file orientjs.d.ts added now .

@saeedtabrizi
Copy link
Contributor Author

Hi @maggiolo00
Based on #184 you can use alternative source for defintion file updates .
also you can use typescript token in package.json to show where is orientjs.d.ts file in orientjs package .

{
.
.
.
"main": "./lib/index.js",
"typescript": {
"definition": "./lib/orientjs.d.ts"
},
.
.
.
}

Best Regards
Saeed Tabrizi

@wolf4ood
Copy link
Member

wolf4ood commented Jul 6, 2016

hi @saeedtabrizi
thanks

Based on #184

Do the pull #93 still need to be merged?

@saeedtabrizi
Copy link
Contributor Author

hi @maggiolo00
that depends on your road map exactly .
if you decide to have a portable typescript compatible package for orientjs just add the latest orientjs.d.ts to your project and make a minor change to package.json for identify typescript definition file .

...
  "typescript": {
    "definition": "lib/orientjs.d.ts"
  },
 .... 

but if you want to have independent package you can undo pull #93 from orientjs . in this way you can have a pure guide document for installing typescript definition file as i wrote on #184 .

Personally , i like orientjs package contains the latest typescript definition file for maintain updates syncing problem .

Best Regards
Saeed Tabrizi

@saeedtabrizi saeedtabrizi deleted the typescript branch October 16, 2016 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants