Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Drop down in grid #202

Merged
merged 9 commits into from
Sep 25, 2023
Merged

FIX: Drop down in grid #202

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6f734bf
! Build problem
JindrichSusen Dec 28, 2022
0cc075b
+ onWindowMove to ModalWindow
JindrichSusen Dec 28, 2022
ece54ee
~ version to 1.6.0
JindrichSusen Dec 28, 2022
142d7e7
Merge branch 'master' of https://github.com/origam/js-components
JindrichSusen Dec 28, 2022
1945b0c
Merge branch 'master' of https://github.com/origam/js-components
JindrichSusen Apr 3, 2023
81d8023
! Drop down was not working in grid in firefox
JindrichSusen Sep 25, 2023
f6dbf67
~ version to 1.6.3
JindrichSusen Sep 25, 2023
fe66ef8
Merge branch 'master' of https://github.com/origam/js-components
JindrichSusen Sep 25, 2023
fef2688
Merge branch 'master' into drop-down-in-grid
JindrichSusen Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/Dropdown/DropdownLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ export function DropdownLayout(props: {
useEffect(() => {
let intervalHandle: any;
const handleScroll = _.throttle((event: any) => {
if (elmDropdownPortal && !elmDropdownPortal.contains(event.target) && props.isDropped) {
if (
elmDropdownPortal &&
!elmDropdownPortal.contains(event.target) &&
event.target.tagName !== "INPUT" && // the scroll event is fired in the focused INPUT after clicking the drop icon in firefox. Preventing the dropdown from being shown.
props.isDropped)
{
console.log(event);
props.onDropupRequest?.();
}
}, 100);
Expand Down