Skip to content

Commit

Permalink
FIX: Combobox highlighting was not removed after selection (#2581)
Browse files Browse the repository at this point in the history
Other covered cases: clicking outside and pressing esc
  • Loading branch information
JindrichSusen committed Apr 3, 2024
1 parent 6620e23 commit 21e9a2e
Showing 1 changed file with 4 additions and 0 deletions.
Expand Up @@ -160,6 +160,7 @@ export class DropdownEditorBehavior implements IDropdownEditorBehavior {
if (this.isDropped) {
this.ensureRequestCancelled();
this.userEnteredValue = undefined;
this.dataTable.setFilterPhrase("");
this.dataTable.clearData();
this.isDropped = false;
this.willLoadPage = 1;
Expand Down Expand Up @@ -264,6 +265,7 @@ export class DropdownEditorBehavior implements IDropdownEditorBehavior {
case "Escape":
this.dropUp();
this.userEnteredValue = undefined;
this.dataTable.setFilterPhrase("");
if (wasDropped) {
event.closedADropdown = true;
return;
Expand Down Expand Up @@ -403,6 +405,8 @@ export class DropdownEditorBehavior implements IDropdownEditorBehavior {
handleTableCellClicked(event: any, visibleRowIndex: any) {
const id = this.dataTable.getRowIdentifierByIndex(visibleRowIndex);
this.data.chooseNewValue(id);
this.userEnteredValue = "";
this.dataTable.setFilterPhrase("");
this.dropUp();
}

Expand Down

0 comments on commit 21e9a2e

Please sign in to comment.