FIX: Row state fetching fix (#1798)

* Some screens could not be loaded because of an exception when fetching row states
* It is possible to adjust debouncing delay via RowStatesDebouncingDelayMilliSeconds in appsettings.json

backend/Origam.Server/Common/PortalResult.cs

@@ -144,5 +144,6 @@ public int MaxRequestLength
         public IFilteringConfig FilteringConfig { get; set; }
 
         public string InitialScreenId { get; set; }
+        public int RowStatesDebouncingDelayMilliSeconds { get; set; }
     }
 }

backend/Origam.Server/Configuration/HtmlClientConfig.cs

@@ -3,5 +3,6 @@
     public class HtmlClientConfig
     {
         public bool ShowToolTipsForMemoFieldsOnly { get; set; }
+        public int RowStatesDebouncingDelayMilliSeconds { get; set; } = 200;
     }
 }

backend/Origam.Server/Controller/UIServiceController.cs

@@ -1217,6 +1217,7 @@ private void AddConfigData(PortalResult result)
                 : chatConfig.ChatRefreshInterval;
             result.CustomAssetsRoute = customAssetsConfig.RouteToCustomAssetsFolder;
             result.ShowToolTipsForMemoFieldsOnly = htmlClientConfig.ShowToolTipsForMemoFieldsOnly;
+            result.RowStatesDebouncingDelayMilliSeconds = htmlClientConfig.RowStatesDebouncingDelayMilliSeconds;
             result.FilteringConfig = clientFilteringConfig;
         }
     }

backend/Origam.Server/TemplateFiles/_appsettings.json

@@ -142,7 +142,8 @@
     ]
   },
   "HtmlClientConfig":{
-    "ShowToolTipsForMemoFieldsOnly" : "false"
+    "ShowToolTipsForMemoFieldsOnly" : "false",
+    "RowStatesDebouncingDelayMilliSeconds": 200
   },
   "Logging": {
 	"LogLevel": {

frontend-html/src/model/entities/RowState.ts

@@ -28,6 +28,7 @@ import { handleError } from "model/actions/handleError";
 import { flashColor2htmlColor } from "@origam/utils";
 import { visibleRowsChanged } from "gui/Components/ScreenElements/Table/TableRendering/renderTable";
 import { getDataSource } from "model/selectors/DataSources/getDataSource";
+import { CancellablePromise } from "mobx/lib/api/flow";
 
 const defaultRowStatesToFetch = 100;
 
@@ -41,8 +42,10 @@ export class RowState implements IRowState {
   suppressWorkingStatus: boolean = false;
   visibleRowIds: string[] = [];
 
-  constructor(data: IRowStateData) {
-    Object.assign(this, data);
+  constructor(debouncingDelayMilliSeconds?: number) {
+    this.triggerLoadDebounced = _.debounce(
+      this.triggerLoadImm,
+      debouncingDelayMilliSeconds == undefined ? 200 : debouncingDelayMilliSeconds);
     visibleRowsChanged.subscribe((visibleRows) => {
       const dataSource = getDataSource(this);
       if (!visibleRows || dataSource.identifier !== visibleRows.dataSourceId) {
@@ -77,7 +80,9 @@ export class RowState implements IRowState {
     }
     return this.visibleRowIds.length === 0
       ? Array.from(this.requests.values()).slice(-defaultRowStatesToFetch)
-      : this.visibleRowIds.map(rowId => this.requests.get(rowId)!);
+      : this.visibleRowIds
+            .map(rowId => this.requests.get(rowId))
+            .filter(x => x !== undefined) as unknown as IterableIterator<RowStateRequest>;
   }
 
   *triggerLoad(loadAll: boolean): any {
@@ -139,7 +144,7 @@ export class RowState implements IRowState {
       this.temporaryRequestsValues = undefined;
     }
   }
-  triggerLoadDebounced = _.debounce(this.triggerLoadImm, 200);
+  triggerLoadDebounced: any;
 
   getValue(rowId: string) {
     if (!this.requests.has(rowId)) {

frontend-html/src/model/entities/WorkbenchLifecycle/WorkbenchLifecycle.ts

@@ -550,6 +550,7 @@ export class WorkbenchLifecycle implements IWorkbenchLifecycle {
       showWorkQueues: portalInfo.workQueueListRefreshInterval > 0,
       helpUrl: portalInfo.helpUrl,
       showToolTipsForMemoFieldsOnly: portalInfo.showToolTipsForMemoFieldsOnly,
+      rowStatesDebouncingDelayMilliSeconds: portalInfo.rowStatesDebouncingDelayMilliSeconds,
       filterConfig: {
         caseSensitive: portalInfo.filteringConfig.caseSensitive,
         accentSensitive: portalInfo.filteringConfig.accentSensitive

frontend-html/src/model/entities/types/IPortalSettings.ts

@@ -24,5 +24,6 @@ export interface IPortalSettings {
   showWorkQueues: boolean;
   helpUrl: string;
   showToolTipsForMemoFieldsOnly: boolean;
+  rowStatesDebouncingDelayMilliSeconds: number;
   filterConfig: IFilterConfig;
 }

frontend-html/src/xmlInterpreters/screenXml.ts

@@ -95,6 +95,7 @@ import { getMomentFormat, replaceDefaultDateFormats } from "./getMomentFormat";
 import { getTablePanelView } from "../model/selectors/TablePanelView/getTablePanelView";
 import { isMobileLayoutActive } from "model/selectors/isMobileLayoutActive";
 import { ScreenFocusManager } from "model/entities/ScreenFocusManager";
+import { getWorkbenchLifecycle } from "model/selectors/getWorkbenchLifecycle";
 
 
 function getPropertyParameters(node: any) {
@@ -223,6 +224,7 @@ export function*interpretScreenXml(
   isLazyLoading: boolean
 ) {
   const workbench = getWorkbench(formScreenLifecycle);
+  const workbenchLifeCycle = getWorkbenchLifecycle(formScreenLifecycle);
   const $workbench = scopeFor(workbench);
   const panelConfigurations = new Map<string, IPanelConfiguration>(
     panelConfigurationsRaw.map((pcr: any) => [
@@ -331,7 +333,7 @@ export function*interpretScreenXml(
     // isSessioned: windowXml.attributes.UseSession,
     dataSources: dataSourcesXml.elements.map((dataSource: any) => {
       return new DataSource({
-        rowState: new RowState({}),
+        rowState: new RowState(workbenchLifeCycle.portalSettings?.rowStatesDebouncingDelayMilliSeconds),
         entity: dataSource.attributes.Entity,
         dataStructureEntityId: dataSource.attributes.DataStructureEntityId,
         identifier: dataSource.attributes.Identifier,