FIX: Add a new item to combobox failed when there were non null fields (

#2202) * Adding a new item to combobox failed if the underlying field required a non null value * Properties hidden were made visible by mistake
origam · Nov 20, 2023 · affbb41 · affbb41
1 parent beef531
commit affbb41
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/backend/Origam.Schema.LookupModel/SchemaItems/NewRecordScreenBinding.cs b/backend/Origam.Schema.LookupModel/SchemaItems/NewRecordScreenBinding.cs
@@ -49,8 +49,8 @@ public class NewRecordScreenBinding : AbstractSchemaItem, IAuthorizationContextC
     public NewRecordScreenBinding(Guid schemaExtensionId) : base(schemaExtensionId) { }
 
     public NewRecordScreenBinding(Key primaryKey) : base(primaryKey)	{}
-
-
+    
+    [Browsable(false)]
     public bool IsAvailable
     {
         get

diff --git a/backend/Origam.Schema/AbstractSchemaItem.cs b/backend/Origam.Schema/AbstractSchemaItem.cs
@@ -642,6 +642,7 @@ private AbstractSchemaItem GetRootItem(AbstractSchemaItem parentItem)
 				return GetRootItem(parentItem.ParentItem);
 		}
 
+		[Browsable(false)]
 		public IEnumerable<AbstractSchemaItem> Parents
 		{
 			get

diff --git a/backend/Origam.Server/Session Stores/NewRecordSessionStore.cs b/backend/Origam.Server/Session Stores/NewRecordSessionStore.cs
@@ -67,6 +67,7 @@ public override void Init()
             row, true, SecurityManager.CurrentUserProfile().Id);
         row.Table.NewRow();
 
+        RemoveNullConstraints(dataSet);
         dataSet.Tables[rootEntity.Name].Rows.Add(row);
         SetDataSource(dataSet);
     }

diff --git a/backend/Origam.Server/Session Stores/SessionStore.cs b/backend/Origam.Server/Session Stores/SessionStore.cs
@@ -756,7 +756,7 @@ public virtual void OnDispose()
         #endregion
 
         #region Private Methods
-        private static void RemoveNullConstraints(DataSet dataset)
+        protected static void RemoveNullConstraints(DataSet dataset)
         {
             foreach (DataTable table in dataset.Tables)
             {