Skip to content

Commit

Permalink
FIX: "is null" filter (#2139)
Browse files Browse the repository at this point in the history
Filter wasn't working in eagerly loaded grids when used on aggregated numeric column.
  • Loading branch information
JindrichSusen committed Nov 7, 2023
1 parent 8961591 commit d662d0d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions frontend-html/src/model/entities/FilterConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export class FilterConfiguration implements IFilterConfiguration {
}
case "Number": {
if (cellValue === undefined) return true;
const t1 = prop.column === "Number" ? parseFloat(cellValue) : cellValue;
const t1 = parseFloat(cellValue);

switch (term.setting.type) {
case "between": {
Expand Down Expand Up @@ -303,9 +303,9 @@ export class FilterConfiguration implements IFilterConfiguration {
if (term.setting.val1 === "" || term.setting.val1 === undefined) return true;
return t1 !== parseFloat(term.setting.val1);
case "nnull":
return t1 !== null;
return cellValue !== null;
case "null":
return t1 === null;
return cellValue === null;
}
break;
}
Expand Down

0 comments on commit d662d0d

Please sign in to comment.