Referenceindexnoupdated #1148
Merged
Referenceindexnoupdated #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on ORIGAM Community. There might be relevant details there: https://community.origam.com/t/action-in-architect-find-references-does-not-work/2602/2 |
JindrichSusen
requested changes
Dec 8, 2022
| if (!item.IsDeleted) | ||
| { | ||
| Add(item); | ||
| } | ||
| } | ||
|
|
||
| private static void RemoveAllReferencs(AbstractSchemaItem reference) |
There was a problem hiding this comment.
Please fix the typo on the method name.
| private static void RemoveAllReferencs(AbstractSchemaItem reference) | ||
| { | ||
| var referenceInfo = new ReferenceInfo(reference.Id, reference.GetType()); | ||
| var referencelist = referenceDictionary |
There was a problem hiding this comment.
Please fix capitalization of the variable name. Or better yet rename it to referencesToRemove?
There was a problem hiding this comment.
I ment the variable "referencelist" not the parameter "reference"
JindrichSusen
requested changes
Dec 9, 2022
| private static void RemoveAllReferencs(AbstractSchemaItem reference) | ||
| { | ||
| var referenceInfo = new ReferenceInfo(reference.Id, reference.GetType()); | ||
| var referencelist = referenceDictionary |
There was a problem hiding this comment.
I ment the variable "referencelist" not the parameter "reference"
JindrichSusen
approved these changes
Dec 15, 2022
washibana
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.