Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Grid editors open in a modal window were not repositioned after … #1206

Merged
merged 2 commits into from Dec 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions frontend-html/package.json
Expand Up @@ -16,7 +16,7 @@
"@decorize/bind": "^1.0.3",
"@mapbox/geojson-area": "^0.2.2",
"@messageformat/core": "^3.0.1",
"@origam/components": "^1.5.4",
"@origam/components": "^1.6.1",
"@origam/plugin-audit": "^2.0.0",
"@origam/plugin-chart": "^2.0.1",
"@origam/plugin-filter": "^2.0.1",
Expand Down Expand Up @@ -102,7 +102,9 @@
},
"resolutions": {
"@types/react": "17.0.2",
"@types/react-dom": "17.0.2"
"@types/react-dom": "17.0.2",
"@types/leaflet": "1.7.11",
"@types/leaflet-draw": "1.0.5"
},
"jest": {
"testEnvironment": "jsdom",
Expand Down
2 changes: 2 additions & 0 deletions frontend-html/src/gui/Components/Dialog/ModalDialog.tsx
Expand Up @@ -33,6 +33,7 @@ export const ModalDialog: React.FC<{
height?: number;
topPosiotionProc?: number;
onKeyDown?: (event: any) => void;
onWindowMove?: (top: number, left: number)=>void;
}> = (props) => {
const application = useContext(MobXProviderContext).application

Expand All @@ -49,6 +50,7 @@ export const ModalDialog: React.FC<{
fullScreen={isMobileLayoutActive(application)}
topPosiotionProc={props.topPosiotionProc}
onKeyDown={props.onKeyDown}
onWindowMove={props.onWindowMove}
>
{props.children}
</ModalWindow>
Expand Down
Expand Up @@ -86,6 +86,7 @@ export const DialogScreen: React.FC<{
}
buttonsCenter={null}
buttonsLeft={null}
onWindowMove={(top, left)=> props.openedScreen.onWindowMove(top, left)}
buttonsRight={
<Observer>
{() =>
Expand Down
30 changes: 30 additions & 0 deletions frontend-html/src/model/entities/OpenedScreen.ts
Expand Up @@ -98,6 +98,36 @@ export class OpenedScreen implements IOpenedScreen {
screen.parent = this;
}

@observable
private top: number | undefined;
@observable
private left: number | undefined;
private originalTop: number | undefined;
private originalLeft: number | undefined;

onWindowMove(top: number, left: number){
if(this.originalLeft === undefined){
this.originalLeft = left;
}
if(this.originalTop === undefined){
this.originalTop = top;
}
this.left = left;
this.top = top;
}

get positionOffset(): {[key: string]: number}{
let topOffset = 0;
let leftOffset = 0;
if(this.top !== undefined && this.originalTop !== undefined){
topOffset = this.top - this.originalTop;
}
if(this.left !== undefined && this.originalLeft !== undefined){
leftOffset = this.left - this.originalLeft;
}
return {topOffset: topOffset, leftOffset: leftOffset}
}

parent?: any;
canRefresh = true;
}
Expand Up @@ -51,6 +51,7 @@ import { getGrouper } from "model/selectors/DataView/getGrouper";
import { IConfigurationManager } from "model/entities/TablePanelView/types/IConfigurationManager";
import { isMobileLayoutActive } from "model/selectors/isMobileLayoutActive";
import { ColumnConfigurationModel } from "model/entities/TablePanelView/ColumnConfigurationModel";
import { getOpenedScreen } from "model/selectors/getOpenedScreen";

export class TablePanelView implements ITablePanelView {
$type_ITablePanelView: 1 = 1;
Expand Down Expand Up @@ -460,7 +461,15 @@ export class TablePanelView implements ITablePanelView {
rowHeight: 0,
};
}
return this.rectangleMap.get(rowIndex + cellOffset.row)!.get(columnIndex + cellOffset.column)!;
const rectangle = this.rectangleMap.get(rowIndex + cellOffset.row)!.get(columnIndex + cellOffset.column)!;
const openedScreen = getOpenedScreen(this);

return {
columnLeft: rectangle.columnLeft + openedScreen.positionOffset.leftOffset,
columnWidth: rectangle.columnWidth,
rowTop: rectangle.rowTop + openedScreen.positionOffset.topOffset,
rowHeight: rectangle.rowHeight
};
}

setCellRectangle(rowId: number, columnId: number, rectangle: ICellRectangle) {
Expand Down
7 changes: 7 additions & 0 deletions frontend-html/src/model/entities/WebScreen.ts
Expand Up @@ -85,4 +85,11 @@ export class WebScreen implements IWebScreen, IOpenedScreen {
parentContext: IOpenedScreen | undefined;

activationHandler = new EventHandler();

onWindowMove(top: number, left: number): void {
}

get positionOffset(): { [p: string]: number } {
return {topOffset: 0, leftOffset: 0};
}
}
3 changes: 3 additions & 0 deletions frontend-html/src/model/entities/types/IOpenedScreen.ts
Expand Up @@ -60,6 +60,9 @@ export interface IOpenedScreen extends IOpenedScreenData {
screenUrl?: string;
parent?: any;
hasDynamicTitle: boolean;

onWindowMove(top: number, left: number): void;
get positionOffset(): {[key: string]: number};
}

export const isIOpenedScreen = (o: any): o is IOpenedScreen =>
Expand Down